[ 
https://issues.apache.org/jira/browse/FLINK-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109525#comment-15109525
 ] 

ASF GitHub Bot commented on FLINK-3262:
---------------------------------------

Github user greghogan commented on the pull request:

    https://github.com/apache/flink/pull/1525#issuecomment-173371188
  
    Ah, okay, so I ran the UI but neglected to note that the "fonts" were 
missing. Turns out the spec for [bower.json](
    https://github.com/bower/spec/blob/master/json.md#main) now prefers 
pre-processed files. Font Awesome was 
[updated](https://github.com/FortAwesome/Font-Awesome/commit/7cde41ea934f43e66dc123ea6411d8535b50a4f7)
 for the new spec and our `gulpfile.js` needed to be modified to include 
`font-awesome.css` in the aggregated `vendor.css`.
    
    Rather than downgrading Font Awesome back to 4.3.0 or including an override 
in `bower.json` I updated `gulpfile.js` to pre-process and include any `LESS` 
files in bower dependencies (as was already being done for Flink's 
`bootstrap_custom.less`).


> Remove fuzzy versioning from Bower dependencies
> -----------------------------------------------
>
>                 Key: FLINK-3262
>                 URL: https://issues.apache.org/jira/browse/FLINK-3262
>             Project: Flink
>          Issue Type: Improvement
>          Components: Webfrontend
>    Affects Versions: 1.00
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Trivial
>
> {{bower.json}} is currently defined with fuzzy versions, i.e. {{"bootstrap": 
> "~3.3.5"}}, which silently pull in patch updates. When a user compiles the 
> web frontend the new versions are creating changes in the compiled Javascript 
> and CSS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to