gaoyunhaii commented on pull request #12224: URL: https://github.com/apache/flink/pull/12224#issuecomment-630232870
@kl0u Could you also help look at a diff to `StreamingFileSink`: https://github.com/apache/flink/pull/12224/files#diff-0d4e6ae7ecf6cd602a986c2dc0e7abbd ? Currently `StreamingFileSink` has two same constructors for `RowFormatBuilder` and `BulkFormatBuilder`, do you think it is ok to merge the two constructors into one that accepts arbitrary `BucketsBuilder` ? This could reduce repeat codes, and it could also enable us to reuse StreamingFileSink for test with another `BucketsBuilder` implementation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
