[
https://issues.apache.org/jira/browse/FLINK-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110903#comment-17110903
]
Gyula Fora commented on FLINK-17619:
------------------------------------
We could do it either way, If you review the PR and happy I can make the same
change to the other source and add a similar test
> Only set offset commit if group id is configured for Kafka Table source
> -----------------------------------------------------------------------
>
> Key: FLINK-17619
> URL: https://issues.apache.org/jira/browse/FLINK-17619
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Kafka, Table SQL / API
> Affects Versions: 1.10.0, 1.11.0
> Reporter: Gyula Fora
> Assignee: Gyula Fora
> Priority: Major
> Fix For: 1.11.0
>
>
> Currently the KafkaTableSourceBase always creates the KafkaConsumer with the
> default offset commiting behavior that will try to commit on checkpoints.
> However this will fail if group.id is not specified which is an optional
> parameter.
> We should disable offset commiting if group.id wasnt specified.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
