[ 
https://issues.apache.org/jira/browse/FLINK-17745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111007#comment-17111007
 ] 

Kostas Kloudas commented on FLINK-17745:
----------------------------------------

Hi all, from the removed code in the PR, we were traversing the user jar and we 
were adding the found nested jars in classpath *only* if they were packaged in 
a {{lib/}} folder. We were expecting a *specific structure* of the jar.  See 
the {{getContainedJarEntries()}} in the removed code.

Given that this feature was not documented, I am not sure if anyone is actually 
using it. Do you have any such cases? If yes, then I agree that the code should 
not be removed and I will close the PR.

> PackagedProgram' extractedTempLibraries and jarfiles may be duplicate
> ---------------------------------------------------------------------
>
>                 Key: FLINK-17745
>                 URL: https://issues.apache.org/jira/browse/FLINK-17745
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client / Job Submission
>    Affects Versions: 1.11.0
>            Reporter: lisen
>            Assignee: Kostas Kloudas
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.11.0
>
>
> When i submit a flink app with a fat jar, PackagedProgram will extracted temp 
> libraries by the fat jar, and add to pipeline.jars, and the pipeline.jars 
> contains  fat jar and temp libraries. I don't think we should add fat jar to 
> the pipeline.jars if extractedTempLibraries is not empty.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to