dawidwys commented on a change in pull request #12228:
URL: https://github.com/apache/flink/pull/12228#discussion_r427268991
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/EqualiserCodeGenerator.scala
##########
@@ -57,9 +59,8 @@ class EqualiserCodeGenerator(fieldTypes: Array[LogicalType]) {
// TODO merge ScalarOperatorGens.generateEquals.
val (equalsCode, equalsResult) = if (isInternalPrimitive(fieldType)) {
("", s"$leftFieldTerm == $rightFieldTerm")
- } else if (isRowData(fieldType)) {
- val equaliserGenerator = new EqualiserCodeGenerator(
- fieldType.asInstanceOf[RowType].getChildren.asScala.toArray)
+ } else if (isCompositeType(fieldType)) {
Review comment:
sorry that was a comment for myself :sweat_smile: forgot to remove it...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
