zentol commented on a change in pull request #12248:
URL: https://github.com/apache/flink/pull/12248#discussion_r427432577
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/FileUploadHandlerTest.java
##########
@@ -256,6 +257,14 @@ public void testUploadCleanupOnFailure() throws
IOException {
verifyNoFileIsRegisteredToDeleteOnExitHook();
}
+ private OkHttpClient createOkHttpClientWithNoTimeouts() {
+ return new OkHttpClient().newBuilder()
Review comment:
maybe use `new OkHttpClient.Builder()...`, it's a bit odd that we are
creating 2 clients?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
