[
https://issues.apache.org/jira/browse/FLINK-17826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111894#comment-17111894
]
Jark Wu commented on FLINK-17826:
---------------------------------
Hi [~f.pompermaier], the options and validation should be added in
{{JdbcDynamicTableSourceSinkFactory}}, besides we may need to update
{{JdbcDynamicTableSource}} just like what you updated on the
{{JdbcTableSource}}.
> Add missing custom query support on new jdbc connector
> ------------------------------------------------------
>
> Key: FLINK-17826
> URL: https://issues.apache.org/jira/browse/FLINK-17826
> Project: Flink
> Issue Type: Sub-task
> Components: Connectors / JDBC
> Reporter: Jark Wu
> Priority: Major
> Fix For: 1.11.0
>
>
> In FLINK-17361, we added custom query on JDBC tables, but missing to add the
> same ability on new jdbc connector (i.e.
> {{JdbcDynamicTableSourceSinkFactory}}).
> In the new jdbc connector, maybe we should call it {{scan.query}} to keep
> consistent with other scan options, besides we need to make {{"table-name"}}
> optional, but add validation that "table-name" and "scan.query" shouldn't
> both be empty, and "table-name" must not be empty when used as sink.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
