Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1536#issuecomment-173607167
I have quickly checked out your branch and came up with another variant for
reworking the KMeans example with the `ParameterTool`:
https://github.com/rmetzger/flink/blob/4c3b569b522172043fe1f49da2858bae37519eef/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java
I didn't use the required parameters, because they make the code too clumsy.
I also think that getting rid of all these static variables and methods is
a great improvement in readability. Users new to Flink should be able to focus
on understanding the Flink's APIs and abstractions and not be distracted by our
examples.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
