[
https://issues.apache.org/jira/browse/FLINK-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110949#comment-15110949
]
ASF GitHub Bot commented on FLINK-3258:
---------------------------------------
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1538
[FLINK-3258] [runtime, streaming-java, tests] Move registerInputOutput code
to invoke and remove registerInputOutput
This removes the `registerInputOutput` method and move the respective code
to the `invoke` method. The separation was an artifact of the old Nephele
runtime, which has become obsolete now. With this change, the contract for
`AbstractInvokable` is easier (`invoke` needs to clean up everything it sets
up).
Includes #1537, because it appears more often with initialization in
`invoke`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink 3258-invokable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1538.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1538
----
commit bed375f5d152a55b941aa87523855abc685827f7
Author: Ufuk Celebi <[email protected]>
Date: 2016-01-19T11:56:52Z
[FLINK-3258] [runtime, streaming-java, tests] Move registerInputOutput code
to invoke and remove registerInputOutput
commit 5650c692817bdc4bcd19c0544b838a3c61f66492
Author: Ufuk Celebi <[email protected]>
Date: 2016-01-20T09:15:54Z
[FLINK-3258] [runtime] Don't request partition on channel update if no
requests yet
commit 8146430f01e0b3d05efde65b8f7a3e5b07041ae8
Author: Aljoscha Krettek <[email protected]>
Date: 2016-01-21T16:21:09Z
[FLINK-3261] Allow Task to decline checkpoint request if not ready
Before, it could happen that a StreamingTask receives a Checkpoint
Trigger message while internally not being ready. The checkpoint
coordinator would then wait the specified timeout interval before
continuing. Now, tasks can signal that they are not ready and the
checkpoint coordinator will dicard a checkpoint for which is this the
case and trigger new checkpoints if necessary.
The newly triggered checkpoints will also release alignment locks in
streaming tasks that are still waiting for barriers from failed
checkpoints.
----
> Merge AbstractInvokable's registerInputOutput and invoke
> --------------------------------------------------------
>
> Key: FLINK-3258
> URL: https://issues.apache.org/jira/browse/FLINK-3258
> Project: Flink
> Issue Type: Improvement
> Reporter: Ufuk Celebi
> Assignee: Ufuk Celebi
> Fix For: 1.0.0
>
>
> The separation between {{registerInputOutput}} and {{invoke}} in
> {{AbstractInvokable}} is an artifact of previous Flink versions. The
> {{registerInputOutput}} method used to trigger the creation of input and
> output gates. This has become obsolete as the task itself takes care of this
> now and {{registerInputOutput}} only requests the input/output gates.
> The contract of having a single {{invoke}} method, which cleans up after
> itself is easier to implement than applying it to two methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
