Github user ChengXiangLi commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1540#discussion_r50505552
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/distributions/DataDistribution.java
 ---
    @@ -47,6 +49,12 @@
         */
        Object[] getBucketBoundary(int bucketNum, int totalNumBuckets);
        
    +   public int[] getBoundaryKeyPositions();
    --- End diff --
    
    Why add these interfaces? the partition key position is defined by user 
through `partitionByRange` parameter, and the partition key type information is 
extracted by flink itself, you should not depends on `DataDistribution` to have 
these information.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to