[ 
https://issues.apache.org/jira/browse/FLINK-17878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113882#comment-17113882
 ] 

Yun Gao edited comment on FLINK-17878 at 5/22/20, 9:20 AM:
-----------------------------------------------------------

Hi [~zhoujira86] I think you are right that the transient value will be set to 
0 after deserialization and the behavior is different from StreamingFileSink 
(which inherits the currentWatermarkField from StreamSink) and it should make 
differences for the records before the first watermark. [~lzljs3620320] could 
double confirm on this issue. 

One more thing, this issue seems to be belong to Table SQL / API instead of API 
/ DataStream (labeled in the component field of this issue) ?


was (Author: gaoyunhaii):
Hi [~zhoujira86] I think you are right that the transient value will be set to 
0 after deserialization and the behavior is different from StreamingFileSink 
(which inherits the currentWatermarkField from StreamSink) and it should make 
differences for the records before the first watermark. [~lzljs3620320] could 
double confirm on this issue. 

One more thing, this issue seems to be belong to Table SQL / API instead of API 
/ DataStream (labeled in the component field of this issue).

> StreamingFileWriter watermark attribute is transient, this might be different 
> with origin value
> -----------------------------------------------------------------------------------------------
>
>                 Key: FLINK-17878
>                 URL: https://issues.apache.org/jira/browse/FLINK-17878
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / DataStream
>    Affects Versions: 1.11.0
>            Reporter: xiaogang zhou
>            Priority: Major
>
> StreamingFileWriter has a 
> private transient long currentWatermark = Long.MIN_VALUE;
>  
> in case developer wants to create a custom bucket assigner, it will receive a 
> currentWatermark as 0, this might be conflict with the original flink 
> approach to handle a min_long.
>  
> should we remove the transient key word?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to