TengHu commented on pull request #8885:
URL: https://github.com/apache/flink/pull/8885#issuecomment-632942879


   > This is a very good feature! Sorry for taking so (extremely) long to 
finally review this. I didn't initially see this PR.
   > 
   > Could you please address my comments?
   > 
   > Also, when creating a PR the individual commits should also have summaries 
according to the Jira issue, i.e. `[FLINK-XXXXX] Add ...`.
   
   > This is a very good feature! Sorry for taking so (extremely) long to 
finally review this. I didn't initially see this PR.
   > 
   > Could you please address my comments?
   > 
   > Also, when creating a PR the individual commits should also have summaries 
according to the Jira issue, i.e. `[FLINK-XXXXX] Add ...`.
   
   Thanks for getting back to me. I've lost the original fork (it's been a year 
since I did this change), so I created a new PR 
https://github.com/apache/flink/pull/12297.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to