StephanEwen opened a new pull request #12306: URL: https://github.com/apache/flink/pull/12306
## What is the purpose of the change This PR integrates the new Watermark Generators introduced as part of [FLIP-126](https://cwiki.apache.org/confluence/display/FLINK/FLIP-126%3A+Unify+%28and+separate%29+Watermark+Assigners) with the new Source Interface introduced in [FLIP-27](https://cwiki.apache.org/confluence/display/FLINK/FLIP-27%3A+Refactor+Source+Interface) A discussion about the design approach is under the JIRA issue [FLINK-17899](https://issues.apache.org/jira/browse/FLINK-17899) ## Brief change log The main changes in this PR are: 1. The introduction of `SourceOutputWithWatermarks` which is a `SourceOutput` that internally runs the `TimestampAssigner` and `WatermarkGenerator` 2. The extension of the `SourceReader`'s output parameter from `SourceOutput` to `ReaderOutput`. The `ReaderOutput` extends the `SourceOutput` and additionally allows the creation of *"split-local"* Source Outputs, to run the watermark generation logic per split. 3. Using the `WatermarkOutputMultiplexer` to combine the watermarks from the split-local outputs. 4. A bunch of utils to create and setup these classes, considering streaming (generate watermarks) and batch (no watermarks). This PR also includes `[FLINK-17898]` (Remove Exceptions from signatures of SourceOutput) and `[FLINK-17897]` (Classify FLIP-27 source API as @PublicEvolving) as pre-processing, to avoid merge conflicts later. ## Verifying this change This PR is only covered in a shallow way by existing tests. More tests are needed. This PR currently served only as a base of review of the production code implementation. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): **no** - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **yes** - The serializers: **no** - The runtime per-record code paths (performance sensitive): **yes** - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no** - The S3 file system connector: **no** ## Documentation - Does this pull request introduce a new feature? **yes** - If yes, how is the feature documented? **not documented** **Documentation of the new features is still undecided - it is possible that this feature stays a "hidden" feature in the upcoming release** ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
