cyq89051127 commented on a change in pull request #12289:
URL: https://github.com/apache/flink/pull/12289#discussion_r429744678
##########
File path:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/util/HBaseTypeUtils.java
##########
@@ -81,13 +81,16 @@ public static Object deserializeToObject(byte[] value, int
typeIdx, Charset stri
* Serialize the Java Object to byte array with the given type.
*/
public static byte[] serializeFromObject(Object value, int typeIdx,
Charset stringCharset) {
+ if (value == null){
+ return EMPTY_BYTES;
Review comment:
Yeah, i get it. f there's an emtpy value sent to deserializeToObject,
It's not a NPE exception.
Do you think we should handle the exception in this PR?
If not, i could create another issue to track the exception in
deserializeToObject.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
