[ 
https://issues.apache.org/jira/browse/FLINK-17898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115818#comment-17115818
 ] 

Aljoscha Krettek commented on FLINK-17898:
------------------------------------------

I would be in factor of unchecked exceptions, because as you said, the source 
cannot handle the exceptions.

> Remove Exceptions from signatures of SourceOutput methods
> ---------------------------------------------------------
>
>                 Key: FLINK-17898
>                 URL: https://issues.apache.org/jira/browse/FLINK-17898
>             Project: Flink
>          Issue Type: Sub-task
>          Components: API / DataStream
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Blocker
>             Fix For: 1.11.0
>
>
> The {{collect(...)}} methods in {{SourceOutput}} currently declare that they 
> can {{trow Exception}}.
> That was originally introduced, because it can be the case when pushing 
> records into the chain.
> However, one can argue that the Source Reader that calls these methods is in 
> no way supposed to handle these exceptions, because they come from downstream 
> operator failures. Because of that, we should go for unchecked exceptions and 
> handle downstream exceptions via {{ExceptionInChainedOperatorException}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to