aljoscha commented on a change in pull request #12317:
URL: https://github.com/apache/flink/pull/12317#discussion_r429811204
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java
##########
@@ -1067,15 +1085,19 @@ static void setJobManagerAddressInConfig(Configuration
config, InetSocketAddress
* @param commandLine The input to the command-line.
* @return custom command-line which is active (may only be one at a
time)
*/
- public CustomCommandLine getActiveCustomCommandLine(CommandLine
commandLine) {
+ public CustomCommandLine validateAndGetActiveCommandLine(CommandLine
commandLine) {
LOG.debug("Custom commandlines: {}", customCommandLines);
for (CustomCommandLine cli : customCommandLines) {
LOG.debug("Checking custom commandline {}, isActive:
{}", cli, cli.isActive(commandLine));
if (cli.isActive(commandLine)) {
return cli;
}
}
- throw new IllegalStateException("No command-line ran.");
+
+ throw new IllegalStateException(
+ "No valid command-line found. If you were
targeting a Yarn cluster, please make sure to have " +
+ "hadoop in your classpath. For more information
refer to the \"Deployment & Operations\" section " +
Review comment:
```suggestion
"Hadoop in your classpath. For more information
refer to the \"Deployment & Operations\" section " +
```
maybe also say sth about`HADOOP_CLASSPATH` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
