zentol commented on a change in pull request #12264:
URL: https://github.com/apache/flink/pull/12264#discussion_r429893280
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironmentTest.java
##########
@@ -100,6 +105,27 @@ public void testRegisterTaskWithInsufficientBuffers()
throws Exception {
testRegisterTaskWithLimitedBuffers(bufferCount);
}
+ @Test
+ public void testSlowIODoesNotBlockRelease() throws Exception {
+ BlockerSync sync = new BlockerSync();
Review comment:
I used a BlockerSync since it allows blocking without throwing checked
exceptions.
`OneShotLatch#await` throwing `InterruptedException` is a bit annoying.
Maybe we should change that; for testing purposes it seems irrelevant?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
