godfreyhe opened a new pull request #12342: URL: https://github.com/apache/flink/pull/12342
## What is the purpose of the change *Currently, proctime defined in ddl can't work with over window in Table api (there is an example in [FLINK-17751](https://issues.apache.org/jira/browse/FLINK-17751)) . The reason is: the type of proctime is `TIMESTAMP(3) NOT null`, while `LegacyTypeInfoDataTypeConverter` does not handle the mapping between `Types.LOCAL_DATE_TIME` and `DataTypes.TIMESTAMP(3)` with not null. The solution is: ignore data type's nullable when finding a data type in `dataTypeTypeInfoMap`* ## Brief change log - *ignore data type's nullable when finding a data type in `LegacyTypeInfoDataTypeConverter#canConvertToTimeAttributeTypeInfo` method * ## Verifying this change This change added tests and can be verified as follows: - *Remove the ignore annotation from TableSourceTest#testProcTimeTableSourceOverWindow* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
