kl0u commented on a change in pull request #12179: URL: https://github.com/apache/flink/pull/12179#discussion_r429985424
########## File path: flink-clients/src/main/java/org/apache/flink/client/cli/ClientOptions.java ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.client.cli; + +import org.apache.flink.configuration.AkkaOptions; +import org.apache.flink.configuration.ConfigOption; +import org.apache.flink.configuration.ConfigOptions; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.util.TimeUtils; + +import java.time.Duration; +import java.util.Optional; + +/** + * Describes a client configuration parameter. + */ +public class ClientOptions { + Review comment: I think that the `CLIENT_TIMEOUT` should subsume the `EMBEDDED_RPC_TIMEOUT` and the `EMBEDDED_RPC_RETRY_PERIOD` should become `CLIENT_RETRY_PERIOD`. So the class should have these 2 options: ``` public static final ConfigOption<Duration> CLIENT_TIMEOUT = ConfigOptions.key("client.timeout") .durationType() .defaultValue(Duration.ofMillis(60 * 1000)) .withDescription("The client timeout (in ms) when executing commands from Flink's CLI or its " + "clients (default 1min)."); public static final ConfigOption<Duration> CLIENT_RETRY_PERIOD = ConfigOptions.key("client.retry-period") .durationType() .defaultValue(Duration.ofMillis(2000)) .withDescription("The interval (in ms) between consecutive retries of failed attempts to execute " + "commands through the CLI or Flink's clients, wherever retry is supported (default 2sec)."); ``` ########## File path: flink-clients/src/main/java/org/apache/flink/client/cli/ClientOptions.java ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.client.cli; + +import org.apache.flink.configuration.AkkaOptions; +import org.apache.flink.configuration.ConfigOption; +import org.apache.flink.configuration.ConfigOptions; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.util.TimeUtils; + +import java.time.Duration; +import java.util.Optional; + +/** + * Describes a client configuration parameter. + */ +public class ClientOptions { + Review comment: You can simply remove the `EMBEDDED_RPC_TIMEOUT` because this was introduced in this release, so it is not released yet. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
