JingsongLi commented on a change in pull request #12323:
URL: https://github.com/apache/flink/pull/12323#discussion_r430859922
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/PartitionCommitPolicy.java
##########
@@ -121,4 +122,20 @@
}
}).collect(Collectors.toList());
}
+
+ /**
+ * Validate commit policy.
+ */
+ static void validatePolicyChain(boolean isEmptyMetastore, String
policyKind) {
+ if (policyKind != null) {
+ String[] policyStrings = policyKind.split(",");
+ for (String policy : policyStrings) {
+ if (isEmptyMetastore &&
METASTORE.equalsIgnoreCase(policy)) {
+ throw new ValidationException(
+ "Can not configure a
metastore partition commit policy for" +
+ " a
table without metastore.");
Review comment:
I think we can just say `file system connector`.
`Can not configure a 'metastore' partition commit policy for a file system
table. You can only configure 'metastore' partition commit policy for a hive
table.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
