godfreyhe opened a new pull request #12355:
URL: https://github.com/apache/flink/pull/12355
## What is the purpose of the change
*FLINK-17728 supports parsing statements via sql parser, the
SqlCommandParser will parse a statement via sql parser first (only
ValidationException will be checked). If parse failed, then SqlCommandParser
parses a statement via regex matching. So the SqlParseException and other
exception are missing. The pr aims to fix this. The solution is changing the
parse strategy: try to use regex matching to find a command. if nothing is
found, use sql parser to parse the statement and don't catch any exception in
SqlCommandParser.*
## Brief change log
- *Update the parse strategy*
- *Catch and print the SqlExecutionException in CliClient#parseCommand
method*
## Verifying this change
This change added tests and can be verified as follows:
- *Simplify SqlCommandParseTest*
- *add CliClientTest#testCreateTableWithInvalidDdl case to validate the
case mentioned in the jira*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
