xintongsong opened a new pull request #12357:
URL: https://github.com/apache/flink/pull/12357
## What is the purpose of the change
This PR fix the problem that `MathUtils.divideRoundUp(0, x)` returns `1`
when `x > 1`. This problem causes Flink Kubernetes deployment keeps requesting
for new pods even there's no pending resource requests.
## Brief change log
- Update `MathUtils#divideRoundUp` to properly handle zero and negative
values.
- Add test cases for `MathUtils#divideRoundUp`
## Verifying this change
- Add test cases in `MathUtilsTest`
- Manually verified that problem of improper requesting pod on K8s is fixed
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
