Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1546#issuecomment-174518267
Thank you for this patch. The idea is good, but I think it needs a bit of
improvement:
- The value is pulled in a fairly complicated way though all the layers
and abstractions. That is not really necessary, as soon as it is in the
`ExecutionConfig`, the `Task` can access the values. No need to change the
TaskDeploymentDescriptior, JobGraph, ExecutionGraph, etc. This probably needs
changes in 2 files (otherwise, our abstractions are messed up).
- `taskCancellationDelay` is not a very intuitive name, in my opinion. It
suggests that cancellation is delayed, which is not the case. Tasks are
actually canceled a single time, the blocked threads are only repeatedly
interrupted.
- We should not try to show off such parameters in the examples. The
examples need to stay simple, or we confuse people with parameters they need
usually not worry about.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
