zhijiangW opened a new pull request #12406:
URL: https://github.com/apache/flink/pull/12406
## What is the purpose of the change
The race condition happens as following:
- CheckpointBarrierUnaligner#notifyBarrierReceived triggers an async
checkpoint(ch1) in mailbox by netty thread.
- CheckpointBarrierUnaligner#processBarrier also triggers a sync
checkpoint(ch2) by task thread and executes immediately.
- When ch1 is taken from mailbox by task thread to execute, it will
cause illegal argument exception because it is smaller than the previous
executed ch2.
For async checkpoint action, before it is actual executing, we can compare
its id with previous executed checkpoint id. If it is not larger than the
previous one, we should ignore it to exit directly.
## Brief change log
- *Fix the race condition between
CheckpointBarrierUnaligner#processBarrier and #notifyBarrierReceived*
- *Recyle the buffer when exception from ChannelStateWriter.addInputData*
- *Fix the formatting of CheckpointBarrierUnaligner*
## Verifying this change
- *Added
CheckpointBarrierUnalignerTest#testBufferRecycleOnNotifyBufferReceivedException*
- *Added
CheckpointBarrierUnalignerTest#testConcurrentProcessBarrierAndNotifyBarrierReceived*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
