pnowojski opened a new pull request #12407:
URL: https://github.com/apache/flink/pull/12407
This removes `NextRecordResponse` and inlines
`NonSpanningWrapper#getNextRecord` to fix second performance regression that
happened on May 19th. This second regression is visible as a difference between
results from Mat 19th (before regression) and May 22nd - 29th (period after
fixing the first performance regression):
http://codespeed.dak8s.net:8000/timeline/?ben=networkBroadcastThroughput&env=2
It was introduced by the following commit:
> [824100e1460dd2f78f689da72bc5d7b0c9dcbbde] [FLINK-17547][task][hotfix]
Extract methods from RecordsDeserializer
`networkBroadcastThroughput` benchmark results are restored from ~1000 to
~1100 ops/ms on the Hetzner worker.
## Verifying this change
Change is covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (**yes** / no
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
