pnowojski commented on a change in pull request #12401:
URL: https://github.com/apache/flink/pull/12401#discussion_r432823980
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -276,6 +281,7 @@ protected StreamTask(
this.actionExecutor =
Preconditions.checkNotNull(actionExecutor);
this.mailboxProcessor = new
MailboxProcessor(this::processInput, mailbox, actionExecutor);
this.mailboxProcessor.initMetric(environment.getMetricGroup());
+ this.mainMailboxExecutor = new MailboxExecutorImpl(mailbox,
MIN_PRIORITY, actionExecutor);
Review comment:
I was thinking about doing here:
```
this.mainMailboxExecutor = mailboxProcessor.getMainMailboxExecutor();
```
or
```
this.mainMailboxExecutor = mailboxProcessor.getMinPriorityMailboxExecutor();
```
to maintain the contract, that everything goes via `MailboxProcessor` one
way or another.
As it is now, some actions are going via `mailbox` and `actionExecutor`
bypassing the processor, which I'm not sure if it's as clean? But I'm not
entirely sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
