zhuzhurk commented on a change in pull request #12278:
URL: https://github.com/apache/flink/pull/12278#discussion_r433113663



##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolRequestCompletionTest.java
##########
@@ -103,7 +123,7 @@ private void runSlotRequestCompletionTest(
                        // check that the slot requests get completed in 
sequential order
                        for (int i = 0; i < slotRequestIds.size(); i++) {
                                final CompletableFuture<PhysicalSlot> 
slotRequestFuture = slotRequests.get(i);
-                               slotRequestFuture.get();
+                               assertThat(slotRequestFuture.getNow(null), 
not(is(nullValue())));

Review comment:
       OK.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to