libenchao commented on a change in pull request #12429:
URL: https://github.com/apache/flink/pull/12429#discussion_r433588491
##########
File path: docs/dev/table/common.md
##########
@@ -32,12 +32,11 @@ Main Differences Between the Two Planners
1. Blink treats batch jobs as a special case of streaming. As such, the
conversion between Table and DataSet is also not supported, and batch jobs will
not be translated into `DateSet` programs but translated into `DataStream`
programs, the same as the streaming jobs.
2. The Blink planner does not support `BatchTableSource`, use bounded
`StreamTableSource` instead of it.
-3. The Blink planner only support the brand new `Catalog` and does not support
`ExternalCatalog` which is deprecated.
-4. The implementations of `FilterableTableSource` for the old planner and the
Blink planner are incompatible. The old planner will push down
`PlannerExpression`s into `FilterableTableSource`, while the Blink planner will
push down `Expression`s.
-5. String based key-value config options (Please see the documentation about
[Configuration]({{ site.baseurl }}/dev/table/config.html) for details) are only
used for the Blink planner.
-6. The implementation(`CalciteConfig`) of `PlannerConfig` in two planners is
different.
-7. The Blink planner will optimize multiple-sinks into one DAG (supported only
on `TableEnvironment`, not on `StreamTableEnvironment`). The old planner will
always optimize each sink into a new DAG, where all DAGs are independent of
each other.
-8. The old planner does not support catalog statistics now, while the Blink
planner does.
+3. The implementations of `FilterableTableSource` for the old planner and the
Blink planner are incompatible. The old planner will push down
`PlannerExpression`s into `FilterableTableSource`, while the Blink planner will
push down `Expression`s.
+4. String based key-value config options (Please see the documentation about
[Configuration]({{ site.baseurl }}/dev/table/config.html) for details) are only
used for the Blink planner.
+5. The implementation(`CalciteConfig`) of `PlannerConfig` in two planners is
different.
+6. The Blink planner will optimize multiple-sinks into one DAG (supported only
on `TableEnvironment`, not on `StreamTableEnvironment`). The old planner will
always optimize each sink into a new DAG, where all DAGs are independent of
each other.
+7. The old planner does not support catalog statistics now, while the Blink
planner does.
Review comment:
https://ci.apache.org/projects/flink/flink-docs-master/dev/table/common.html#translate-and-execute-a-query
https://ci.apache.org/projects/flink/flink-docs-master/dev/table/common.html#query-optimization
These two places have tabs 'blink' and 'old planner', do you think we can
put 'blink' section above 'old planner' section, then blink will be shown to
the user by default (no need to have one more click).
##########
File path: docs/dev/table/catalogs.md
##########
@@ -63,7 +63,7 @@ Set a `JdbcCatalog` with the following parameters:
<div data-lang="Java" markdown="1">
{% highlight java %}
-EnvironmentSettings settings =
EnvironmentSettings.newInstance().useBlinkPlanner().inStreamingMode().build();
+EnvironmentSettings settings =
EnvironmentSettings.newInstance().inStreamingMode().build();
Review comment:
also update for `hive/index.md` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
