twalthr commented on a change in pull request #11397:
URL: https://github.com/apache/flink/pull/11397#discussion_r433640661
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/config/entries/DeploymentEntry.java
##########
@@ -161,7 +165,11 @@ public static DeploymentEntry enrich(DeploymentEntry
deployment, Map<String, Str
});
final DescriptorProperties properties = new
DescriptorProperties(true);
- properties.putProperties(enrichedProperties);
+ try {
Review comment:
instead of throwing a `SqlExecutionException` in a configuration class,
we should rather throw it in the `LocalExecutor`. All those methods already
define a `throws SqlExecutionException`. This also allows to catch exceptions
in both `DeploymentEntry` and `EnvironmentEntry` and `ConfigurationEntry` at
the same time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
