zhijiangW opened a new pull request #12438:
URL: https://github.com/apache/flink/pull/12438
## What is the purpose of the change
RemoteInputChannel#onBuffer is invoked by
CreditBasedPartitionRequestClientHandler while receiving and decoding the
network data. #onBuffer can throw exceptions which would tag the error in
client handler and fail all the added input channels inside handler. Then it
would cause a tricky potential issue as following.
If the RemoteInputChannel is canceling by canceler thread, then the task
thread might exit early than canceler thread terminate. That means the
PartitionRequestClient might not be closed (triggered by canceler thread) while
the new task attempt is already deployed into the same TaskManager. Therefore
the new task might reuse the previous PartitionRequestClient while requesting
partitions, but note that the respective client handler was already tagged an
error before during above RemoteInputChannel#onBuffer, to cause the next round
unnecessary failover.
The solution is to only fail the respective task when its internal
RemoteInputChannel#onBuffer throws any exceptions instead of failing the whole
channels inside client handler, then the client is still healthy and can also
be reused by other input channels as long as it is not released yet.
## Brief change log
Not fail the whole network client handler while exception in
`RemoteInputChannel#onBuffer`
## Verifying this change
Added new unit test
`CreditBasedPartitionRequestClientHandlerTest#testRemoteInputChannelOnBufferException`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
