godfreyhe commented on a change in pull request #12346:
URL: https://github.com/apache/flink/pull/12346#discussion_r434354823
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/result/MaterializedCollectStreamResult.java
##########
@@ -224,7 +224,7 @@ private void processDelete(Row row) {
}
for (int i = startSearchPos; i >= validRowPosition; i--) {
- if (materializedTable.get(i).equals(row)) {
+ if (materializedTable.get(i).fieldsEquals(row)) {
materializedTable.remove(i);
rowPositionCache.remove(row);
Review comment:
@twalthr for now, we can erase the row kind for `Tuple2<Boolean, Row>`.
After https://github.com/apache/flink/pull/12199 merged, I want to refactor the
select logic in sql client. Then `Tuple2` is not needed, we can use `Row` for
all cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
