[
https://issues.apache.org/jira/browse/FLINK-18074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124759#comment-17124759
]
Piotr Nowojski edited comment on FLINK-18074 at 6/3/20, 8:37 AM:
-----------------------------------------------------------------
Yes, I think you are right. I've missed that {{notifyCheckpointCompleteAsync}}
is also using {{submit}} (clearly we are missing a test coverage for that).
I've assigned the ticket to you.
was (Author: pnowojski):
Yes, I think you are right. I've missed that {{notifyCheckpointCompleteAsync}}
is also using {{submit}} (clearly we are missing a test coverage for that).
> Confirm checkpoint completed on task side would not fail the task if
> exception thrown out
> -----------------------------------------------------------------------------------------
>
> Key: FLINK-18074
> URL: https://issues.apache.org/jira/browse/FLINK-18074
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing, Runtime / Task
> Affects Versions: 1.11.0
> Reporter: Yun Tang
> Assignee: Yun Tang
> Priority: Blocker
> Fix For: 1.11.0
>
>
> FLINK-17350 let the task fail immediately once sync phase of checkpoint
> failed. However, the included commit ['Simplify checkpoint exception
> handling'|https://github.com/apache/flink/pull/12101/commits/a2cd3daceca16ae841119d94a24328b4af37dcd8]
> actually would not fail the task if the runnable of {{() ->
> notifyCheckpointComplete}} throwing exception out.
> In a nutshell, this actually changes previous checkpoint exception handling.
> Moreover, that part of code also affect the implemented code of
> {{notifyCheckpointAbortAsync}} when I introduce {{notifyCheckpointAborted}}
> on task side.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
