danny0405 commented on a change in pull request #12355:
URL: https://github.com/apache/flink/pull/12355#discussion_r434415772
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/SqlCommandParser.java
##########
@@ -253,8 +247,10 @@ private SqlCommandParser() {
// supports both `explain xx` and `explain plan for xx` now
// TODO should keep `explain xx` ?
EXPLAIN(
- "EXPLAIN\\s+(.*)",
- SINGLE_OPERAND),
+ "EXPLAIN\\s+(SELECT|INSERT)\\s+(.*)",
+ (operands) -> {
+ return Optional.of(new String[] { operands[0],
operands[1] });
Review comment:
Add some comment to explain why to match the `SELECT` and `INSERT`
keyword explicitly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
