Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1552#discussion_r50959035
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/util/EnvironmentInformation.java
---
@@ -70,10 +70,9 @@ public static RevisionInformation
getRevisionInformation() {
revision = propRevision != null ? propRevision
: UNKNOWN;
commitDate = propCommitDate != null ?
propCommitDate : UNKNOWN;
}
- }
- catch (Throwable t) {
+ } catch (IOException ex) {
--- End diff --
I would like to keep catching `Throwable`, or at least `Exception` here, as
this is a method that should not error out in any case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
