twalthr commented on a change in pull request #12396:
URL: https://github.com/apache/flink/pull/12396#discussion_r434536658
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ComparableTypeStrategy.java
##########
@@ -169,8 +173,7 @@ private boolean areDistinctTypesComparable(LogicalType
firstType, LogicalType se
}
private boolean areStructuredTypesComparable(LogicalType firstType,
LogicalType secondType) {
- return firstType.equals(secondType) &&
- hasRequiredComparision((StructuredType) firstType);
+ return firstType.equals(secondType) &&
hasRequiredComparision((StructuredType) firstType);
}
private boolean areCollectionsComparable(LogicalType firstType,
LogicalType secondType) {
Review comment:
nit: a row is not really a collection, according to SQL standard and
LogicalTypeFamily I would rather call this `areConstructedTypesComparable`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
