HuangZhenQiu commented on a change in pull request #11541:
URL: https://github.com/apache/flink/pull/11541#discussion_r434888634
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactoryTest.java
##########
@@ -130,6 +134,56 @@ public void run() {
}
}
+ @Test
+ public void testNettyClientConnectRetry() throws Exception {
+ NettyTestUtil.NettyServerAndClient serverAndClient =
NettyTestUtil.initServerAndClient(
+ new NettyProtocol(null, null) {
+
+ @Override
+ public ChannelHandler[]
getServerChannelHandlers () {
+ return new ChannelHandler[0];
+ }
+
+ @Override
+ public ChannelHandler[]
getClientChannelHandlers () {
+ return new
ChannelHandler[]{mock(NetworkClientHandler.class)};
+ }
Review comment:
NettyPartitionRequestClient constructor has a precondition check for
ChannelHandler != null. Thus, I have to create a mock object here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
