aljoscha commented on a change in pull request #12325:
URL: https://github.com/apache/flink/pull/12325#discussion_r435099153



##########
File path: docs/dev/table/tableApi.md
##########
@@ -227,6 +227,50 @@ Table orders = tableEnv.from("Orders");
 {% endhighlight %}
       </td>
        </tr>
+       <tr>
+      <td>
+            <strong>Values</strong><br>
+            <span class="label label-primary">Batch</span> <span class="label 
label-primary">Streaming</span>
+      </td>
+      <td>
+          <p>Similar to the VALUES clause in a SQL query. Produces an inline 
table out of the provided rows.</p>
+          <p>You can use a `row(...)` expression to create a composite 
rows:</p>

Review comment:
       ```suggestion
             <p>You can use a `row(...)` expression to create composite 
rows:</p>
   ```

##########
File path: docs/dev/table/tableApi.md
##########
@@ -227,6 +227,50 @@ Table orders = tableEnv.from("Orders");
 {% endhighlight %}
       </td>
        </tr>
+       <tr>
+      <td>
+            <strong>Values</strong><br>
+            <span class="label label-primary">Batch</span> <span class="label 
label-primary">Streaming</span>
+      </td>
+      <td>
+          <p>Similar to the VALUES clause in a SQL query. Produces an inline 
table out of the provided rows.</p>
+          <p>You can use a `row(...)` expression to create a composite 
rows:</p>
+{% highlight java %}
+Table table = tEnv.fromValues(
+   row(1, "ABC"),
+   row(2L, "ABCDE")
+);
+{% endhighlight %}
+          <p>will produce a Table with a schema as follows:</p>
+{% highlight text %}
+root
+|-- f0: BIGINT NOT NULL     // original types INT and BIGINT are generalized 
to BIGINT
+|-- f1: VARCHAR(5) NOT NULL // original types CHAR(3) and CHAR(5) are 
generalized
+                            // to VARCHAR(5). It uses VARCHAR instead of CHAR 
so that
+                            // no padding is applied

Review comment:
       ```suggestion
   |-- f1: VARCHAR(5) NOT NULL // original types CHAR(3) and CHAR(5) are 
generalized
                               // to VARCHAR(5). VARCHAR is used instead of 
CHAR so that
                               // no padding is applied
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to