xintongsong commented on a change in pull request #12399:
URL: https://github.com/apache/flink/pull/12399#discussion_r435648217
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskSubmissionTestEnvironment.java
##########
@@ -167,6 +157,21 @@ private TaskSubmissionTestEnvironment(
taskExecutor.start();
taskExecutor.waitUntilStarted();
+
Review comment:
I'm not sure about this.
`taskManagerServices` is used for creating the `taskExecutor`, which itself
should guarantee to always access `taskSlotTable` in the RPC main thread. If
there's something wrong that `taskExecutor` doesn't guarantee this, it would be
better to fail the tests. Using `threadSafeTaskSlotTable` here might cover such
problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
