SteNicholas commented on a change in pull request #12476:
URL: https://github.com/apache/flink/pull/12476#discussion_r435657301



##########
File path: flink-python/pyflink/table/table_environment.py
##########
@@ -147,30 +147,185 @@ def get_catalog(self, catalog_name):
         else:
             return None
 
-    def load_module(self, module_name: str, module: Module):

Review comment:
       @dianfu I followed the code style from previous, and unified the 
parameter style. Therefore, I removed the type hint.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to