zhijiangW commented on a change in pull request #12493:
URL: https://github.com/apache/flink/pull/12493#discussion_r435674253
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
##########
@@ -310,16 +310,16 @@ private void notifyCheckpoint(CheckpointBarrier barrier)
throws IOException {
public synchronized void
notifyBarrierReceived(CheckpointBarrier barrier, InputChannelInfo channelInfo)
throws IOException {
long barrierId = barrier.getId();
+ int channelIndex =
handler.getFlattenedChannelIndex(channelInfo);
Review comment:
irrelevant changes should be cleanup?
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
##########
@@ -310,16 +310,16 @@ private void notifyCheckpoint(CheckpointBarrier barrier)
throws IOException {
public synchronized void
notifyBarrierReceived(CheckpointBarrier barrier, InputChannelInfo channelInfo)
throws IOException {
long barrierId = barrier.getId();
+ int channelIndex =
handler.getFlattenedChannelIndex(channelInfo);
+ LOG.error("{}: Received barrier from channel {} ({}) @
{}.", handler.taskName, channelIndex, storeNewBuffers[channelIndex], barrierId);
if (currentReceivedCheckpointId < barrierId) {
handleNewCheckpoint(barrier);
handler.executeInTaskThread(() ->
handler.notifyCheckpoint(barrier), "notifyCheckpoint");
}
- int channelIndex =
handler.getFlattenedChannelIndex(channelInfo);
if (barrierId == currentReceivedCheckpointId &&
storeNewBuffers[channelIndex]) {
- if (LOG.isDebugEnabled()) {
- LOG.debug("{}: Received barrier from
channel {} @ {}.", handler.taskName, channelIndex, barrierId);
- }
+// if (LOG.isDebugEnabled()) {
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
