[GitHub] [flink] danny0405 commented on a change in pull request #12483: [FLINK-15339][table][docs] Correct the terminology of "Time-windowed Join" to "Interval Join" in Table API & SQL

[GitBox]

danny0405 commented on a change in pull request #12483:
URL: https://github.com/apache/flink/pull/12483#discussion_r435711748



##########
File path: docs/dev/table/sql/queries.zh.md
##########
@@ -566,15 +566,15 @@ FROM Orders FULL OUTER JOIN Product ON Orders.productId = 
Product.id
       </td>
     </tr>
     <tr>
-      <td><strong>Time-windowed Join</strong><br>
+      <td><strong>Interval Join</strong><br>
         <span class="label label-primary">批处理</span>
         <span class="label label-primary">流处理</span>
       </td>
       <td>
-        <p><b>注意：</b> 时间窗口 join 是常规 join 的子集，可以使用流的方式进行处理。</p>
+        <p><b>注意：</b>Interval join （时间区间关联）是常规 join 的子集，可以使用流的方式进行处理。</p>
 
-        <p>时间窗口join需要至少一个 equi-join 谓词和一个限制了双方时间的 join 
条件。例如使用两个适当的范围谓词（<code>&lt;, &lt;=, &gt;=, &gt;</code>），一个 <code>BETWEEN</code> 
谓词或一个比较两个输入表中相同类型的 <a href="{{ site.baseurl 
}}/zh/dev/table/streaming/time_attributes.html">时间属性</a> （即处理时间和事件时间）的相等谓词</p>
-        <p>比如，以下谓词是合法的窗口 join 条件：</p>
+        <p>Interval join需要至少一个 equi-join 谓词和一个限制了双方时间的 join 
条件。例如使用两个适当的范围谓词（<code>&lt;, &lt;=, &gt;=, &gt;</code>），一个 <code>BETWEEN</code> 
谓词或一个比较两个输入表中相同类型的 <a href="{{ site.baseurl 
}}/zh/dev/table/streaming/time_attributes.html">时间属性</a> （即处理时间和事件时间）的相等谓词</p>
+        <p>比如，以下谓词是合法的 interval join 条件：</p>

Review comment:
       Line 1125, 1134, 1142 also need to modify.

##########
File path: 
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/ProcTimeIntervalStreamJoin.java
##########
@@ -24,13 +24,13 @@
 import org.apache.flink.table.runtime.typeutils.RowDataTypeInfo;
 
 /**
- * The function to execute processing time bounded stream inner-join.
+ * The function to execute processing time interval stream inner-join.
  */
-public final class ProcTimeBoundedStreamJoin extends TimeBoundedStreamJoin {
+public final class ProcTimeIntervalStreamJoin extends TimeIntervalStreamJoin {
 

Review comment:
       What is a interval stream join ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org