azagrebin edited a comment on pull request #12446: URL: https://github.com/apache/flink/pull/12446#issuecomment-639295316
Thanks for the review @tillrohrmann, I will address the comments. The drawback of inheritance is, as usual, having this error handling concern and new inheritance contract in all our class loaders. At the moment, I also do not know any other potential cases where it could hurt and it is indeed ok to go with inheritance in this PR. On the hand, we already tried the decorator way with the similar `getParent` problem in #11303. The approach in #11303 requires decoration to null-out the internal class loader reference. We can tackle it later, of course, if there is no better idea now. All-in-all, I am fine to go with the inheritance in this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
