zhijiangW commented on a change in pull request #12489:
URL: https://github.com/apache/flink/pull/12489#discussion_r435740753
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java
##########
@@ -142,7 +166,7 @@
this.env = checkNotNull(env);
this.asyncExceptionHandler =
checkNotNull(asyncExceptionHandler);
this.actionExecutor = checkNotNull(actionExecutor);
- this.channelStateWriter = unalignedCheckpointEnabled ?
openChannelStateWriter() : ChannelStateWriter.NO_OP;
+ this.channelStateWriter = channelStateWriter;
Review comment:
nit: checkNotNull(channelStateWriter)
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java
##########
@@ -134,6 +132,32 @@
boolean unalignedCheckpointEnabled,
BiFunctionWithException<ChannelStateWriter, Long,
CompletableFuture<Void>, IOException> prepareInputSnapshot,
int maxRecordAbortedCheckpoints) throws IOException {
+ this(checkpointStorage,
Review comment:
nit: `checkpointStorage` argument also in separate line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
