zhijiangW commented on a change in pull request #12460:
URL: https://github.com/apache/flink/pull/12460#discussion_r435761869
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
##########
@@ -404,8 +400,14 @@ synchronized int getNumOpenChannels() {
return numOpenChannels;
}
+ @VisibleForTesting
synchronized long getCurrentCheckpointId() {
return currentReceivedCheckpointId;
}
+
+ @VisibleForTesting
+ boolean isCheckpointPending() {
Review comment:
The only purpose of retaining this method now is for unit tests. For the
main codes, all the callers are already in `synchronized`, and for test usages
it has no race condition issues. So I am a bit torn whether to add
`synchronized` for it, WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
