[ 
https://issues.apache.org/jira/browse/FLINK-18152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126691#comment-17126691
 ] 

Chesnay Schepler edited comment on FLINK-18152 at 6/5/20, 11:24 AM:
--------------------------------------------------------------------

Exceptions due to negative (or in any way malformatted) values also don't fail 
the startup:
{code}
Exception in thread "main" 
org.apache.flink.configuration.IllegalConfigurationException: Cannot read 
memory size from config option 'jobmanager.memory.process.size'.                
                                                                at 
org.apache.flink.runtime.util.config.memory.ProcessMemoryUtils.getMemorySizeFromConfig(ProcessMemoryUtils.java:217)
                                                                                
                                       at 
org.apache.flink.runtime.util.config.memory.ProcessMemoryUtils.deriveProcessSpecWithTotalProcessMemory(ProcessMemoryUtils.java:100)
                                                                                
                       at 
org.apache.flink.runtime.util.config.memory.ProcessMemoryUtils.memoryProcessSpecFromConfig(ProcessMemoryUtils.java:79)
                                                                                
                                    at 
org.apache.flink.runtime.jobmanager.JobManagerProcessUtils.processSpecFromConfig(JobManagerProcessUtils.java:76)
                                                                                
                                          at 
org.apache.flink.runtime.jobmanager.JobManagerProcessUtils.processSpecFromConfigWithNewOptionToInterpretLegacyHeap(JobManagerProcessUtils.java:71)
                                                                                
        at 
org.apache.flink.runtime.util.bash.BashJavaUtils.getJmResourceParams(BashJavaUtils.java:92)
                                                                                
                                                               at 
org.apache.flink.runtime.util.bash.BashJavaUtils.runCommand(BashJavaUtils.java:66)
                                                                                
                                                                        at 
org.apache.flink.runtime.util.bash.BashJavaUtils.main(BashJavaUtils.java:54)    
                                                                                
                                                                  Caused by: 
java.lang.IllegalArgumentException: Could not parse value '-5m' for key 
'jobmanager.memory.process.size'.                                               
                                                                                
  at 
org.apache.flink.configuration.Configuration.getOptional(Configuration.java:753)
                                                                                
                                                                          at 
org.apache.flink.configuration.Configuration.get(Configuration.java:738)        
                                                                                
                                                                          at 
org.apache.flink.runtime.util.config.memory.ProcessMemoryUtils.getMemorySizeFromConfig(ProcessMemoryUtils.java:215)
                                                                                
                                       ... 7 more                               
                                                                                
                                                                                
                            Caused by: java.lang.NumberFormatException: text 
does not start with a number                                                    
                                                                                
                                    at 
org.apache.flink.configuration.MemorySize.parseBytes(MemorySize.java:294)       
                                                                                
                                                                          at 
org.apache.flink.configuration.MemorySize.parse(MemorySize.java:247)            
                                                                                
                                                                          at 
org.apache.flink.configuration.Configuration.convertToMemorySize(Configuration.java:951)
                                                                                
                                                                  at 
org.apache.flink.configuration.Configuration.convertValue(Configuration.java:885)
                                                                                
                                                                         at 
org.apache.flink.configuration.Configuration.lambda$getOptional$2(Configuration.java:750)
                                                                                
                                                                 at 
java.base/java.util.Optional.map(Optional.java:265)                             
                                                                                
                                                                          at 
org.apache.flink.configuration.Configuration.getOptional(Configuration.java:750)
                                                                                
                                                                          ... 9 
more
{code}


was (Author: zentol):
Exceptions due to negative values also don't fail the startup:
{code}
Exception in thread "main" 
org.apache.flink.configuration.IllegalConfigurationException: Cannot read 
memory size from config option 'jobmanager.memory.process.size'.                
                                                                at 
org.apache.flink.runtime.util.config.memory.ProcessMemoryUtils.getMemorySizeFromConfig(ProcessMemoryUtils.java:217)
                                                                                
                                       at 
org.apache.flink.runtime.util.config.memory.ProcessMemoryUtils.deriveProcessSpecWithTotalProcessMemory(ProcessMemoryUtils.java:100)
                                                                                
                       at 
org.apache.flink.runtime.util.config.memory.ProcessMemoryUtils.memoryProcessSpecFromConfig(ProcessMemoryUtils.java:79)
                                                                                
                                    at 
org.apache.flink.runtime.jobmanager.JobManagerProcessUtils.processSpecFromConfig(JobManagerProcessUtils.java:76)
                                                                                
                                          at 
org.apache.flink.runtime.jobmanager.JobManagerProcessUtils.processSpecFromConfigWithNewOptionToInterpretLegacyHeap(JobManagerProcessUtils.java:71)
                                                                                
        at 
org.apache.flink.runtime.util.bash.BashJavaUtils.getJmResourceParams(BashJavaUtils.java:92)
                                                                                
                                                               at 
org.apache.flink.runtime.util.bash.BashJavaUtils.runCommand(BashJavaUtils.java:66)
                                                                                
                                                                        at 
org.apache.flink.runtime.util.bash.BashJavaUtils.main(BashJavaUtils.java:54)    
                                                                                
                                                                  Caused by: 
java.lang.IllegalArgumentException: Could not parse value '-5m' for key 
'jobmanager.memory.process.size'.                                               
                                                                                
  at 
org.apache.flink.configuration.Configuration.getOptional(Configuration.java:753)
                                                                                
                                                                          at 
org.apache.flink.configuration.Configuration.get(Configuration.java:738)        
                                                                                
                                                                          at 
org.apache.flink.runtime.util.config.memory.ProcessMemoryUtils.getMemorySizeFromConfig(ProcessMemoryUtils.java:215)
                                                                                
                                       ... 7 more                               
                                                                                
                                                                                
                            Caused by: java.lang.NumberFormatException: text 
does not start with a number                                                    
                                                                                
                                    at 
org.apache.flink.configuration.MemorySize.parseBytes(MemorySize.java:294)       
                                                                                
                                                                          at 
org.apache.flink.configuration.MemorySize.parse(MemorySize.java:247)            
                                                                                
                                                                          at 
org.apache.flink.configuration.Configuration.convertToMemorySize(Configuration.java:951)
                                                                                
                                                                  at 
org.apache.flink.configuration.Configuration.convertValue(Configuration.java:885)
                                                                                
                                                                         at 
org.apache.flink.configuration.Configuration.lambda$getOptional$2(Configuration.java:750)
                                                                                
                                                                 at 
java.base/java.util.Optional.map(Optional.java:265)                             
                                                                                
                                                                          at 
org.apache.flink.configuration.Configuration.getOptional(Configuration.java:750)
                                                                                
                                                                          ... 9 
more
{code}

> Master starts despite IllegalConfigurationException
> ---------------------------------------------------
>
>                 Key: FLINK-18152
>                 URL: https://issues.apache.org/jira/browse/FLINK-18152
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination
>    Affects Versions: 1.11.0
>            Reporter: Chesnay Schepler
>            Priority: Major
>
> When no memory configuration parameters are set for the Master process then 
> this exception is logged by the BashJavaUtils:
> {code}
> Exception in thread "main" 
> org.apache.flink.configuration.IllegalConfigurationException: Either required 
> fine-grained memory (jobmanager.memory.heap.size), or Total Flink Memory size 
> (Key: 'jobmanager.memory.flink.size' , default: null $        at 
> org.apache.flink.runtime.util.config.memory.ProcessMemoryUtils.failBecauseRequiredOptionsNotConfigured(ProcessMemoryUtils.java:111)
>                                                                               
>                          at 
> org.apache.flink.runtime.util.config.memory.ProcessMemoryUtils.memoryProcessSpecFromConfig(ProcessMemoryUtils.java:81)
>                                                                               
>                                       at 
> org.apache.flink.runtime.jobmanager.JobManagerProcessUtils.processSpecFromConfig(JobManagerProcessUtils.java:76)
>                                                                               
>                                             at 
> org.apache.flink.runtime.jobmanager.JobManagerProcessUtils.processSpecFromConfigWithNewOptionToInterpretLegacyHeap(JobManagerProcessUtils.java:71)
>                                                                               
>           at 
> org.apache.flink.runtime.util.bash.BashJavaUtils.getJmResourceParams(BashJavaUtils.java:92)
>                                                                               
>                                                                  at 
> org.apache.flink.runtime.util.bash.BashJavaUtils.runCommand(BashJavaUtils.java:66)
>                                                                               
>                                                                           at 
> org.apache.flink.runtime.util.bash.BashJavaUtils.main(BashJavaUtils.java:54)
> {code}
> Afterwards, the Master process however continues to start just fine.
> TaskManagers will not be started given the same situation, which is 
> inconsistent behavior, and it seems dangerous to start a process despite an 
> illegal configuration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to