azagrebin commented on a change in pull request #12423:
URL: https://github.com/apache/flink/pull/12423#discussion_r435887345
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/AbstractExecutionSlotAllocator.java
##########
@@ -105,22 +104,11 @@ protected SlotExecutionVertexAssignment
createAndRegisterSlotExecutionVertexAssi
return slotExecutionVertexAssignment;
}
- /**
- * Calculates the preferred locations for an execution.
- * It will first try to use preferred locations based on state,
- * if null, will use the preferred locations based on inputs.
- */
- protected static CompletableFuture<Collection<TaskManagerLocation>>
calculatePreferredLocations(
+ protected CompletableFuture<Collection<TaskManagerLocation>>
calculatePreferredLocations(
Review comment:
Alright, then I believe `preferredLocationsRetriever` and
`pendingSlotAssignments` fields can be private. Also the whole
`AbstractExecutionSlotAllocator` can be package private and its protected
constructor/methods. Any reason to keep them not package private?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
