[ 
https://issues.apache.org/jira/browse/FLINK-18157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126735#comment-17126735
 ] 

Nicholas Jiang commented on FLINK-18157:
----------------------------------------

[~chesnay]Could you please assign this to me? I would like to add method 
verifyJvmOffHeapSize to check compares against offHeapMemory.

> Jobstore size check compares against offHeapMemory
> --------------------------------------------------
>
>                 Key: FLINK-18157
>                 URL: https://issues.apache.org/jira/browse/FLINK-18157
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination
>    Affects Versions: 1.11.0
>            Reporter: Chesnay Schepler
>            Priority: Major
>
> Setting {{jobmanager.memory.off-heap.size}} to 0 results in this confusing 
> error:
> {code}
> [] - Loading configuration property: jobmanager.memory.process.size, 2000m
> [] - Loading configuration property: jobmanager.memory.heap.size, 1500m
> [] - Loading configuration property: jobmanager.memory.jvm-overhead.min, 100m
> [] - Loading configuration property: jobmanager.memory.jvm-overhead.max, 350m
> [] - Loading configuration property: jobmanager.memory.off-heap.size, 0m
> [] - The configured or derived JVM heap memory size (jobstore.cache-size: 0 
> bytes) is less than the configured or default size of the job store cache 
> (jobmanager.memory.heap.size: 50.000mb (52428800 bytes))
> {code}
> According to the documentation the jobstore uses the heap though.
> {code}
> private static JobManagerFlinkMemory createJobManagerFlinkMemory(
>               Configuration config,
>               MemorySize jvmHeap,
>               MemorySize offHeapMemory) {
>       verifyJvmHeapSize(jvmHeap);
>       verifyJobStoreCacheSize(config, offHeapMemory);
>       return new JobManagerFlinkMemory(jvmHeap, offHeapMemory);
> }
> private static void verifyJvmHeapSize(MemorySize jvmHeapSize) {
>       if (jvmHeapSize.compareTo(JobManagerOptions.MIN_JVM_HEAP_SIZE) < 1) {
>               LOG.warn(
>                       "The configured or derived JVM heap memory size ({}) is 
> less than its recommended minimum value ({})",
>                       jvmHeapSize.toHumanReadableString(),
>                       JobManagerOptions.MIN_JVM_HEAP_SIZE);
>       }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to