azagrebin commented on a change in pull request #12446:
URL: https://github.com/apache/flink/pull/12446#discussion_r435926951
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -311,7 +314,12 @@ public static TaskManagerServices fromConfiguration(
permanentBlobService,
BlobLibraryCacheManager.defaultClassLoaderFactory(
taskManagerServicesConfiguration.getClassLoaderResolveOrder(),
-
taskManagerServicesConfiguration.getAlwaysParentFirstLoaderPatterns()));
+
taskManagerServicesConfiguration.getAlwaysParentFirstLoaderPatterns(),
+ classLoadingException -> {
+ if
(ExceptionUtils.isMetaspaceOutOfMemoryError(classLoadingException)) {
+
fatalErrorHandler.onFatalError(classLoadingException);
+ }
Review comment:
We can introduce an advanced user class loader option to decide whether
to fail on Metaspace OOM on user class loading to fallback to the existing
behaviour if needed. The class loading will fail on OOM, by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
