becketqin opened a new pull request #12507:
URL: https://github.com/apache/flink/pull/12507


   ## What is the purpose of the change
   The `AddSplitsEvent` contains a list of `SourceSplit` to be sent from the 
source coordinator to the source reader.  Currently the `AddSplitsEvent` is a 
serializable but the `SourceSplit` is not serializable as we expect the users 
to provide a split serializer. In order to make sure the `AddSplitsEvent` is 
serializable, we need to use the user provided split serializer to save the 
serialized splits in the `AddSplitsEvent` instead of having the split objects.
   
   ## Brief change log
   90d421fc94e29c0af0fa563661b9dd8f2a388b1b changes the `AddSplitsEvent` to 
save the serialized splits instead of the original instance.
   
   ## Verifying this change
   Existing unit tests covers the change.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to