azagrebin commented on a change in pull request #12520:
URL: https://github.com/apache/flink/pull/12520#discussion_r436576187
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/util/config/memory/ProcessMemoryUtils.java
##########
@@ -158,6 +156,25 @@ public JvmMetaspaceAndOverhead
deriveJvmMetaspaceAndOverheadFromTotalFlinkMemory
return jvmMetaspaceAndOverhead;
}
+ private MemorySize
deriveJvmOverheadFromTotalFlinkMemoryAndOtherComponents(
Review comment:
there is a similar check in the method
`deriveJvmMetaspaceAndOverheadWithTotalProcessMemory`, called before:
`jvmMetaspaceAndOverhead.getTotalJvmMetaspaceAndOverheadSize().getBytes() >
totalProcessMemorySize.getBytes()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
